r91066 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91065‎ | r91066 | r91067 >
Date:10:51, 29 June 2011
Author:ialex
Status:ok
Tags:
Comment:
Follow-up r90334 and r90337: made DifferenceEngine::addHeader() non-static to be able to use $this->mTitle instead of $wgTitle
Modified paths:
  • /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceEngine.php
@@ -935,13 +935,13 @@
936936 *
937937 * @return string
938938 */
939 - static function addHeader( $diff, $otitle, $ntitle, $multi = '', $notice = '' ) {
940 - global $wgBetterDirectionality, $wgTitle;
 939+ function addHeader( $diff, $otitle, $ntitle, $multi = '', $notice = '' ) {
 940+ global $wgBetterDirectionality;
941941 $tableClass = 'diff';
942942 if( $wgBetterDirectionality ) {
943943 // shared.css sets diff in interface language/dir,
944944 // but the actual content should be in the page language/dir
945 - $pageLang = $wgTitle->getPageLanguage();
 945+ $pageLang = $this->mTitle->getPageLanguage();
946946 $tableClass .= ' diff-contentalign-' . htmlspecialchars( $pageLang->alignStart() );
947947 }
948948 $header = "<table class='$tableClass'>";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90334Follow-up to r90265: directionality improvements as part of bug 6100 (under $...robin13:12, 18 June 2011
r90337Address comment by Platonides on r90320:...robin14:49, 18 June 2011

Status & tagging log