r91036 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91035‎ | r91036 | r91037 >
Date:00:37, 29 June 2011
Author:demon
Status:ok
Tags:
Comment:
MFT r91031: filepage.css fixes
Modified paths:
  • /branches/wmf/1.17wmf1/includes/AutoLoader.php (modified) (history)
  • /branches/wmf/1.17wmf1/includes/ImagePage.php (modified) (history)
  • /branches/wmf/1.17wmf1/includes/resourceloader (modified) (history)
  • /branches/wmf/1.17wmf1/includes/resourceloader/ResourceLoaderFilePageModule.php (added) (history)
  • /branches/wmf/1.17wmf1/resources/Resources.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/ImagePage.php
@@ -151,11 +151,16 @@
152152 $wgOut->addWikiText( $this->makeMetadataTable( $formattedMetadata ) );
153153 $wgOut->addModules( array( 'mediawiki.legacy.metadata' ) );
154154 }
155 -
156 - $css = $this->repo->getDescriptionStylesheetUrl();
157 - if ( $css ) {
158 - $wgOut->addStyle( $css );
 155+
 156+ // Add remote Filepage.css
 157+ if( !$this->repo->isLocal() ) {
 158+ $css = $this->repo->getDescriptionStylesheetUrl();
 159+ if ( $css ) {
 160+ $wgOut->addStyle( $css );
 161+ }
159162 }
 163+ // always show the local local Filepage.css, bug 29277
 164+ $wgOut->addModuleStyles( 'filepage' );
160165 }
161166
162167 public function getRedirectTarget() {
Property changes on: branches/wmf/1.17wmf1/includes/ImagePage.php
___________________________________________________________________
Added: svn:mergeinfo
163168 Merged /branches/sqlite/includes/ImagePage.php:r58211-58321
164169 Merged /trunk/phase3/includes/ImagePage.php:r83590,89512-89513,91031
165170 Merged /branches/new-installer/phase3/includes/ImagePage.php:r43664-66004
166171 Merged /branches/wmf-deployment/includes/ImagePage.php:r53381,60970
167172 Merged /branches/REL1_15/phase3/includes/ImagePage.php:r51646
168173 Merged /branches/wmf/1.16wmf4/includes/ImagePage.php:r67177,69199,76243,77266
Index: branches/wmf/1.17wmf1/includes/resourceloader/ResourceLoaderFilePageModule.php
@@ -0,0 +1,11 @@
 2+<?php
 3+/*
 4+ * ResourceLoader definition for MediaWiki:Filepage.css
 5+ */
 6+class ResourceLoaderFilePageModule extends ResourceLoaderWikiModule {
 7+ protected function getPages( ResourceLoaderContext $context ) {
 8+ return array(
 9+ 'MediaWiki:Filepage.css' => array( 'type' => 'style' ),
 10+ );
 11+ }
 12+}
Property changes on: branches/wmf/1.17wmf1/includes/resourceloader/ResourceLoaderFilePageModule.php
___________________________________________________________________
Added: svn:eol-style
113 + native
Property changes on: branches/wmf/1.17wmf1/includes/resourceloader
___________________________________________________________________
Added: svn:mergeinfo
214 Merged /branches/new-installer/phase3/includes/resourceloader:r43664-66004
315 Merged /branches/wmf-deployment/includes/resourceloader:r53381,60970
416 Merged /branches/REL1_15/phase3/includes/resourceloader:r51646
517 Merged /branches/wmf/1.16wmf4/includes/resourceloader:r67177,69199,76243,77266
618 Merged /branches/sqlite/includes/resourceloader:r58211-58321
719 Merged /trunk/phase3/includes/resourceloader:r83590,89512-89513,91031
Index: branches/wmf/1.17wmf1/includes/AutoLoader.php
@@ -196,6 +196,7 @@
197197 'ResourceLoaderModule' => 'includes/resourceloader/ResourceLoaderModule.php',
198198 'ResourceLoaderWikiModule' => 'includes/resourceloader/ResourceLoaderWikiModule.php',
199199 'ResourceLoaderFileModule' => 'includes/resourceloader/ResourceLoaderFileModule.php',
 200+ 'ResourceLoaderFilePageModule' => 'includes/resourceloader/ResourceLoaderFilePageModule.php',
200201 'ResourceLoaderSiteModule' => 'includes/resourceloader/ResourceLoaderSiteModule.php',
201202 'ResourceLoaderUserModule' => 'includes/resourceloader/ResourceLoaderUserModule.php',
202203 'ResourceLoaderUserOptionsModule' => 'includes/resourceloader/ResourceLoaderUserOptionsModule.php',
Property changes on: branches/wmf/1.17wmf1/includes/AutoLoader.php
___________________________________________________________________
Modified: svn:mergeinfo
203204 Merged /trunk/phase3/includes/AutoLoader.php:r91031
Index: branches/wmf/1.17wmf1/resources/Resources.php
@@ -8,6 +8,7 @@
99 'startup' => array( 'class' => 'ResourceLoaderStartUpModule' ),
1010 'user' => array( 'class' => 'ResourceLoaderUserModule' ),
1111 'user.options' => array( 'class' => 'ResourceLoaderUserOptionsModule' ),
 12+ 'filepage' => array( 'class' => 'ResourceLoaderFilePageModule' ),
1213
1314 /* Skins */
1415
Property changes on: branches/wmf/1.17wmf1/resources/Resources.php
___________________________________________________________________
Modified: svn:mergeinfo
1516 Merged /trunk/phase3/resources/Resources.php:r91031

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91031(bug 29277) MediaWiki:Filepage.css not loaded on foreignwiki itself. Fixup to...demon00:08, 29 June 2011

Status & tagging log