r91033 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91032‎ | r91033 | r91034 >
Date:00:22, 29 June 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Follow-up r90902: Parse error
Modified paths:
  • /trunk/extensions/CodeReview/modules/ext.codereview.tooltips.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/modules/ext.codereview.tooltips.js
@@ -45,7 +45,7 @@
4646
4747 var tip = '<div class="mw-codereview-status-' + status + '" style="padding:5px 8px 4px; margin:-5px -8px -4px;">';
4848
49 - if ( rev[*] ) {
 49+ if ( rev['*'] ) {
5050 tip += mw.msg( 'code-tooltip-withsummary', matches[2], mw.msg( 'codereview-status-' + status ), author, text );
5151 } else {
5252 tip += mw.msg( 'code-tooltip-withoutsummary', matches[2], mw.msg( 'codereview-status-' + status ), author );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90902* (bug 28259) Localise CR Tooltipsreedy20:03, 27 June 2011

Comments

#Comment by Reedy (talk | contribs)   00:24, 29 June 2011

Oh, that explains it...

Status & tagging log