r91023 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91022‎ | r91023 | r91024 >
Date:22:03, 28 June 2011
Author:nad
Status:deferred
Tags:
Comment:
oops more defaulread stuff to remove
Modified paths:
  • /trunk/extensions/SimpleSecurity/SimpleSecurity.php (modified) (history)
  • /trunk/extensions/SimpleSecurity/SimpleSecurity_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SimpleSecurity/SimpleSecurity_body.php
@@ -167,12 +167,10 @@
168168 */
169169 public function onImgAuthBeforeStream( &$title, &$path, &$name, &$result ) {
170170 global $wgUser;
171 -
172171 if ( !$this->userCanReadTitle( $wgUser, $title, $error )) {
173172 $result = array('img-auth-accessdenied', 'img-auth-noread', $name);
174173 return false;
175174 }
176 -
177175 return true;
178176 }
179177
@@ -201,13 +199,6 @@
202200
203201 $groups = $user->getEffectiveGroups();
204202
205 - # Put the anon read right back in $wgGroupPermissions if it was there initially
206 - # - it had to be removed because Title::userCanRead short-circuits with it
207 - if ( $this->default_read ) {
208 - $wgGroupPermissions['*']['read'] = true;
209 - $rights[] = 'read';
210 - }
211 -
212203 # Filter rights according to $wgPageRestrictions
213204 # - also update LS (rules from local settings) items to info array
214205 $this->pageRestrictions( $rights, $groups, $title, true );
Index: trunk/extensions/SimpleSecurity/SimpleSecurity.php
@@ -22,7 +22,7 @@
2323 * @copyright © 2007-2011 Aran Dunkley
2424 * @license GNU General Public Licence 2.0 or later
2525 */
26 -define( 'SIMPLESECURITY_VERSION', '5.0.3, 2011-06-28' );
 26+define( 'SIMPLESECURITY_VERSION', '5.0.4, 2011-06-29' );
2727
2828 # Load the SimpleSecurity class and messages
2929 $dir = dirname( __FILE__ ) . '/';

Status & tagging log