r90986 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90985‎ | r90986 | r90987 >
Date:18:17, 28 June 2011
Author:krinkle
Status:ok
Tags:
Comment:
per r90984 CR, cleaner this way
Modified paths:
  • /trunk/phase3/resources/mediawiki.special/mediawiki.special.recentchanges.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.special/mediawiki.special.recentchanges.js
@@ -25,11 +25,11 @@
2626 },
2727
2828 init: function() {
29 - // Populate & bind
30 - $select = $( '#namespace' ).change( rc.updateCheckboxes );
 29+ // Populate
 30+ $select = $( '#namespace' );
3131
32 - // Trigger once set the initial statuses of the checkboxes.
33 - $select.change();
 32+ // Bind to change event, and trigger once to set the initial state of the checkboxes.
 33+ $select.change( rc.updateCheckboxes ).change();
3434 }
3535 };
3636

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90984mw.special.recentchanges fixes:...krinkle17:56, 28 June 2011

Status & tagging log