r90962 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90961‎ | r90962 | r90963 >
Date:14:39, 28 June 2011
Author:janpaul123
Status:ok
Tags:
Comment:
Fixed 'Make your own' screen per bug 29622, should hopefully fix it.
Modified paths:
  • /trunk/extensions/WikiLove/WikiLove.i18n.php (modified) (history)
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -331,9 +331,9 @@
332332 $.wikiLove.showError( 'wikilove-err-header' ); return false;
333333 }
334334
335 - // Check for a title if it is required
 335+ // Check for a title if it is required, and otherwise use the header text
336336 if( $.inArray( 'title', currentTypeOrSubtype.fields ) >= 0 && $( '#mw-wikilove-title' ).val().length <= 0 ) {
337 - $.wikiLove.showError( 'wikilove-err-title' ); return false;
 337+ $( '#mw-wikilove-title' ).val( $( '#mw-wikilove-header' ).val() );
338338 }
339339
340340 if( $.inArray( 'message', currentTypeOrSubtype.fields ) >= 0 ) {
Index: trunk/extensions/WikiLove/WikiLove.i18n.php
@@ -27,7 +27,7 @@
2828 'wikilove-image' => 'Enter an image filename:',
2929 'wikilove-select-image' => 'Select an image:',
3030 'wikilove-header' => 'Enter a header:',
31 - 'wikilove-title' => 'Enter a title:',
 31+ 'wikilove-title' => 'Enter an award title:',
3232 'wikilove-enter-message' => 'Enter a message:',
3333 'wikilove-omit-sig' => '(without a signature)',
3434 'wikilove-image-example' => '(example: Trophy.png)',

Status & tagging log