r90949 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90948‎ | r90949 | r90950 >
Date:10:27, 28 June 2011
Author:janpaul123
Status:ok
Tags:
Comment:
Added spinner when checking for image existence
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -292,6 +292,8 @@
293293 } else {
294294 // Make sure the image exists
295295 var imageTitle = $.wikiLove.addFilePrefix( $( '#mw-wikilove-image' ).val() );
 296+ $( '#mw-wikilove-preview-spinner' ).fadeIn( 200 );
 297+
296298 $.ajax( {
297299 url: mw.util.wikiScript( 'api' ),
298300 data: {
@@ -305,6 +307,7 @@
306308 if ( !data.query.pages[-1].imageinfo ) {
307309 // Image does not exist
308310 $.wikiLove.showError( 'wikilove-err-image-bad' );
 311+ $( '#mw-wikilove-preview-spinner' ).fadeOut( 200 );
309312 } else {
310313 // Image exists. Proceed with preview.
311314 $.wikiLove.submitPreview();

Follow-up revisions

RevisionCommit summaryAuthorDate
r93050Test for external links in the sidebar...hashar15:42, 25 July 2011

Status & tagging log