r90944 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90943‎ | r90944 | r90945 >
Date:06:51, 28 June 2011
Author:kaldari
Status:ok
Tags:
Comment:
adding example for custom image field, so that it isnt as mysterious
Modified paths:
  • /trunk/extensions/WikiLove/WikiLove.i18n.php (modified) (history)
  • /trunk/extensions/WikiLove/WikiLove.php (modified) (history)
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/WikiLove.php
@@ -110,6 +110,7 @@
111111 'wikilove-title',
112112 'wikilove-enter-message',
113113 'wikilove-omit-sig',
 114+ 'wikilove-image-example',
114115 'wikilove-button-preview',
115116 'wikilove-preview',
116117 'wikilove-notify',
Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -81,6 +81,7 @@
8282 <label for="mw-wikilove-title" id="mw-wikilove-title-label"><html:msg key="wikilove-title"/></label>\
8383 <input type="text" class="text" id="mw-wikilove-title"/>\
8484 <label for="mw-wikilove-image" id="mw-wikilove-image-label"><html:msg key="wikilove-image"/></label>\
 85+ <span class="mw-wikilove-note" id="mw-wikilove-image-note"><html:msg key="wikilove-image-example"/></span>\
8586 <input type="text" class="text" id="mw-wikilove-image"/>\
8687 <label for="mw-wikilove-message" id="mw-wikilove-message-label"><html:msg key="wikilove-enter-message"/></label>\
8788 <span class="mw-wikilove-note" id="mw-wikilove-message-note"><html:msg key="wikilove-omit-sig"/></span>\
@@ -230,7 +231,7 @@
231232 $( '#mw-wikilove-title' ).val( currentTypeOrSubtype.title || '' );
232233
233234 // show or hide image label and textbox depending on fields configuration
234 - $( '#mw-wikilove-image, #mw-wikilove-image-label')
 235+ $( '#mw-wikilove-image, #mw-wikilove-image-label, #mw-wikilove-image-note' )
235236 .toggle( $.inArray( 'image', currentTypeOrSubtype.fields ) >= 0 );
236237
237238 // set the new text for the image textbox
Index: trunk/extensions/WikiLove/WikiLove.i18n.php
@@ -30,6 +30,7 @@
3131 'wikilove-title' => 'Enter a title:',
3232 'wikilove-enter-message' => 'Enter a message:',
3333 'wikilove-omit-sig' => '(without a signature)',
 34+ 'wikilove-image-example' => '(example: Trophy.png)',
3435 'wikilove-button-preview' => 'Preview',
3536 'wikilove-preview' => 'Preview',
3637 'wikilove-notify' => 'Notify the user by e-mail',
@@ -55,6 +56,7 @@
5657 'wikilove-button-preview' => 'Button text. Verb.',
5758 'wikilove-preview' => 'Title. Noun.',
5859 'wikilove-barnstar-header' => 'See [[:wikipedia:Barnstar]]. Probably not literally translatable.',
 60+ 'wikilove-image-example' => 'The filename should be an actual image on Wikimedia Commons.',
5961 );
6062
6163 /** Bulgarian (Български)

Follow-up revisions

RevisionCommit summaryAuthorDate
r90948Changed default image to Trophy.png, to be consistent with the example added ...janpaul12310:22, 28 June 2011

Status & tagging log