r90903 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90902‎ | r90903 | r90904 >
Date:20:11, 27 June 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r90902, remove old code that was supposed to be deleted

Fixup some whitespace
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)
  • /trunk/extensions/CodeReview/modules/ext.codereview.tooltips.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -253,6 +253,7 @@
254254 private static function makeStateMessageKey( $key ) {
255255 return "code-status-$key";
256256 }
 257+
257258 /**
258259 * List of all flags a user can mark themself as having done to a revision
259260 * @return Array
Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -304,8 +304,7 @@
305305 * {{msg-mw|code-signoff-flag-inspected}}
306306 * {{msg-mw|code-signoff-flag-tested}}',
307307 'code-signoff-field-date' => 'Table column header: timestamp of the sign-off. {{Identical|Date}}',
308 - 'code-signoff-struckdate' => 'This is displayed in the date column for a struck sign-off. $1 is the timestamp of the sign-off, $2 is the timestamp of when it was struck.
309 -Struck is the past tense of verb strike (as in delete).',
 308+ 'code-signoff-struckdate' => 'This is displayed in the date column for a struck sign-off. $1 is the timestamp of the sign-off, $2 is the timestamp of when it was struck. Struck is the past tense of verb strike (as in delete).',
310309 'code-pathsearch-path' => '{{Identical|Path}}',
311310 'code-revfilter-cr_status' => '{{Identical|Status}}',
312311 'code-revfilter-cr_author' => '{{Identical|Author}}',
Index: trunk/extensions/CodeReview/modules/ext.codereview.tooltips.js
@@ -43,13 +43,6 @@
4444 var status = mw.html.escape( rev.status );
4545 var author = mw.html.escape( rev.author );
4646
47 - var tip = '<div class="mw-codereview-status-' + status + '" style="padding:5px 8px 4px; margin:-5px -8px -4px;">'
48 - + 'r' + matches[2]
49 - + ' [' + mw.msg( 'codereview-status-' + status ) + '] by '
50 - + author
51 - + ( rev['*'] ? ' - ' + text : '' )
52 - + '</div>';
53 -
5447 var tip = '<div class="mw-codereview-status-' + status + '" style="padding:5px 8px 4px; margin:-5px -8px -4px;">';
5548
5649 if ( rev[*] ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90902* (bug 28259) Localise CR Tooltipsreedy20:03, 27 June 2011

Status & tagging log