r90890 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90889‎ | r90890 | r90891 >
Date:17:39, 27 June 2011
Author:reedy
Status:ok
Tags:
Comment:
Remove commented out "live" code which we don't use now
Modified paths:
  • /trunk/extensions/CodeReview/modules/ext.codereview.overview.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/modules/ext.codereview.overview.js
@@ -41,7 +41,6 @@
4242 var vpath = $( '#path' ).val();
4343 var totals = {};
4444 $tr.each( function( i ){
45 - var live = 'notlive';
4645 var status = false;
4746
4847 var trc = $(this).attr( 'class' ).split(' ');
@@ -49,9 +48,6 @@
5049 return;
5150 }
5251 for( var j = 0; j < trc.length; j++ ) {
53 - // WMF doesn't use live/not live ATM
54 - // if( /mw\-codereview\-(not|)live/.test( trc[j] ) )
55 - // live = trc[j].substring( 14 );
5652 if( trc[j].substring( 0, 21 ) == 'mw-codereview-status-' ) {
5753 status = trc[j].substring( 21 );
5854 }
@@ -60,7 +56,7 @@
6157
6258 var statusname = $td.filter( '.TablePager_col_cr_status' ).text();
6359
64 - if( !statusname || !status || !live ) {
 60+ if( !statusname || !status ) {
6561 return;
6662 }
6763
@@ -79,15 +75,11 @@
8076 }
8177 overviewPopupData[i]['path'] = path;
8278
83 - //overviewPopupData[i]['live'] = live;
8479 if( !totals[statusname] ) {
8580 totals[statusname] = 0;
8681 }
87 - //if( !totals[live] ) {
88 - // totals[live] = 0;
89 - //}
 82+
9083 totals[statusname]++;
91 - //totals[live]++;
9284
9385 $(this).attr( 'id', 'TablePager-row-' + rev );
9486
@@ -95,7 +87,6 @@
9688 .append( $( '<a href="#box-' + i + '" class="overview-backlink">^</a>' ) );
9789
9890 var $box = $( '<a href="#TablePager-row-' + rev + '" class="box-status-' + status + '" id="box-' + i + '"> </a>' );
99 - // $box.append( document.createTextNode( live ) );
10091 $( '#overviewmap' ).append( $box );
10192 });
10293
@@ -132,7 +123,6 @@
133124 '<div>Number of notes: <span id="overviewpop-notes">' + overviewPopupData[id]['notes'] + '</span></div>' +
134125 '<div>Path: <span id="overviewpop-path">' + overviewPopupData[id]['path'] + '</span></div>' +
135126 '<div>Author: <span id="overviewpop-author">' + overviewPopupData[id]['author'] + '</span></div>' +
136 - //'<div>Live: <span id="overviewpop-live">' + overviewPopupData[id]['live'] + '</span></div>' +
137127 '</div>')
138128 $el.attr( 'title', $popup.html() );
139129 $el.data( 'codeTooltip', true );

Follow-up revisions

RevisionCommit summaryAuthorDate
r90891Kill unused css as of r90890reedy17:40, 27 June 2011
r92308REL1.18: MFT r90889, r90890, r90891, r90893reedy21:34, 15 July 2011

Status & tagging log