r90882 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90881‎ | r90882 | r90883 >
Date:15:47, 27 June 2011
Author:salvatoreingala
Status:deferred
Tags:
Comment:
Some improvements in dialog's appearance
Modified paths:
  • /branches/salvatoreingala/Gadgets/ui/resources/ext.gadgets.preferences.css (modified) (history)
  • /branches/salvatoreingala/Gadgets/ui/resources/ext.gadgets.preferences.js (modified) (history)
  • /branches/salvatoreingala/Gadgets/ui/resources/jquery.formBuilder.js (modified) (history)

Diff [purge]

Index: branches/salvatoreingala/Gadgets/ui/resources/jquery.formBuilder.js
@@ -314,7 +314,7 @@
315315 if ( typeof description.intro == 'string' ) {
316316 $( '<p/>' )
317317 .text( preproc( description.intro ) )
318 - .addClass( 'mw-gadgets-prefsDialog-intro' )
 318+ .addClass( 'formBuilder-intro' )
319319 .appendTo( $form );
320320 }
321321
Index: branches/salvatoreingala/Gadgets/ui/resources/ext.gadgets.preferences.css
@@ -2,9 +2,28 @@
33 * Styles for gadget's preference setting dialogs.
44 */
55
 6+.formBuilder-intro {
 7+ margin-left: 1em;
 8+}
 9+
610 #mw-gadgets-prefsDialog label {
 11+ display: inline-block;
 12+ text-align: right;
 13+ margin-right: 2%;
 14+ width: 45%;
 15+}
 16+
 17+#mw-gadgets-prefsDialog label.error {
718 display: block;
8 - float: left;
9 - width: 250px;
 19+ margin-left: 50%;
 20+ font-size: 90%;
1021 }
1122
 23+#mw-gadgets-prefsDialog input[type="text"] {
 24+ width: 50%;
 25+}
 26+
 27+#mw-gadgets-prefsDialog select {
 28+ width: 40%;
 29+}
 30+
Index: branches/salvatoreingala/Gadgets/ui/resources/ext.gadgets.preferences.js
@@ -76,7 +76,7 @@
7777
7878 $( dialogBody ).dialog( {
7979 modal: true,
80 - width: 'auto',
 80+ width: 550,
8181 resizable: false,
8282 title: mw.msg( 'gadgets-configuration-of', gadget ),
8383 close: function() {
@@ -117,7 +117,8 @@
118118
119119 //Toggle visibility on click to the input
120120 $( input ).click( function() {
121 - $span.fadeToggle( 'fast' );
 121+ var visibility = $span.css( 'visibility' );
 122+ $span.css( 'visibility', visibility == 'visible' ? 'hidden' : 'visible' );
122123 } );
123124 }
124125 } );

Status & tagging log