r90879 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90878‎ | r90879 | r90880 >
Date:15:01, 27 June 2011
Author:janpaul123
Status:ok
Tags:
Comment:
In r90567 the message box was made shown/hidden based on configuration options, but when shown, it was still permitted not to enter a message. That is fixed now.
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -278,15 +278,9 @@
279279 $.wikiLove.showError( 'wikilove-err-header' ); return false;
280280 }
281281
282 - /*
283 - Let's not show an error for not entering a message, making it always optional.
284 - This is preferred over removing the field from the interface, so that users are
285 - stimulated to enter a message, but are not required to do so if they want to leave
286 - a quick gesture of appreciation.
287282 if( $( '#mw-wikilove-message' ).val().length <= 0 ) {
288283 $.wikiLove.showError( 'wikilove-err-msg' ); return false;
289284 }
290 - */
291285
292286 // If there isn't a signature already in the message, throw an error
293287 if ( $( '#mw-wikilove-message' ).val().indexOf( '~~~' ) >= 0 ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90567making message field configurable in preparation for welcome templates, disab...kaldari00:55, 22 June 2011

Status & tagging log