r90868 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90867‎ | r90868 | r90869 >
Date:00:38, 27 June 2011
Author:kaldari
Status:ok
Tags:
Comment:
switching from instanceof Array to jquery.isArray()
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -236,7 +236,7 @@
237237 $( '#mw-wikilove-image' ).val( currentTypeOrSubtype.image || '' );
238238
239239 if( typeof currentTypeOrSubtype.gallery == 'object'
240 - && currentTypeOrSubtype.gallery.imageList instanceof Array
 240+ && $.isArray( currentTypeOrSubtype.gallery.imageList )
241241 ) {
242242 $( '#mw-wikilove-gallery, #mw-wikilove-gallery-label' ).show();
243243 $.wikiLove.showGallery(); // build gallery from array of images

Sign-offs

UserFlagDate
JanPaul123inspected14:22, 27 June 2011

Status & tagging log