r90847 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90846‎ | r90847 | r90848 >
Date:19:33, 26 June 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r89566, r89568, make links point to the user whom the contributions are for (not $wgUser)

Add a comment to go with r90775
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -117,6 +117,8 @@
118118
119119 $feedType = $wgRequest->getVal( 'feed' );
120120 if( $feedType ) {
 121+ // Maintain some level of backwards compatability
 122+ // If people request feeds using the old parameters, redirect to API
121123 $apiParams = array(
122124 'action' => 'feedcontributions',
123125 'feedformat' => $feedType,
@@ -151,7 +153,7 @@
152154 }
153155
154156 // Add RSS/atom links
155 - $this->addFeedLinks( array( 'action' => 'feedcontributions', 'user' => $wgUser->getName() ) );
 157+ $this->addFeedLinks( array( 'action' => 'feedcontributions', 'user' => $target ) );
156158
157159 if ( wfRunHooks( 'SpecialContributionsBeforeMainOutput', array( $id ) ) ) {
158160

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89566Followup r89564...reedy14:56, 6 June 2011
r89568Refactoring to r89566...reedy15:07, 6 June 2011
r90775Followup r89566...reedy16:41, 25 June 2011

Status & tagging log