r90842 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90841‎ | r90842 | r90843 >
Date:19:14, 26 June 2011
Author:kaldari
Status:ok
Tags:
Comment:
removing wgServer since it isnt necessary (also should be called with mw.config.get anyway)
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -427,7 +427,7 @@
428428 window.location.reload();
429429 } else {
430430 window.location = encodeURI(
431 - wgServer + mw.config.get( 'wgArticlePath' ).replace( '$1', mw.util.wikiUrlencode( data.redirect.pageName ) )
 431+ mw.config.get( 'wgArticlePath' ).replace( '$1', mw.util.wikiUrlencode( data.redirect.pageName ) )
432432 + '#' + data.redirect.fragment );
433433 }
434434 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90823mw.util.wikiUrlencode is not meant for encoding entire URLs, or if it is, its...kaldari06:19, 26 June 2011

Status & tagging log