r90826 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90825‎ | r90826 | r90827 >
Date:11:48, 26 June 2011
Author:hashar
Status:ok
Tags:
Comment:
Fix comment in BacklinkCache::partition()
+ a typo

Per cr on r84254
Modified paths:
  • /trunk/phase3/includes/BacklinkCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/BacklinkCache.php
@@ -255,7 +255,7 @@
256256
257257 /**
258258 * Partition the backlinks into batches.
259 - * Returns an array giving the start and end of each range. The firsti
 259+ * Returns an array giving the start and end of each range. The first
260260 * batch has a start of false, and the last batch has an end of false.
261261 *
262262 * @param $table String: the links table name
@@ -264,7 +264,7 @@
265265 */
266266 public function partition( $table, $batchSize ) {
267267
268 - // 1) try this per process cache first
 268+ // 1) try partition cache ...
269269
270270 if ( isset( $this->partitionCache[$table][$batchSize] ) ) {
271271 wfDebug( __METHOD__ . ": got from partition cache\n" );
@@ -274,7 +274,7 @@
275275 $this->partitionCache[$table][$batchSize] = false;
276276 $cacheEntry =& $this->partitionCache[$table][$batchSize];
277277
278 - // 2) try full result cache
 278+ // 2) ... then try full result cache ...
279279
280280 if ( isset( $this->fullResultCache[$table] ) ) {
281281 $cacheEntry = $this->partitionResult( $this->fullResultCache[$table], $batchSize );

Follow-up revisions

RevisionCommit summaryAuthorDate
r92348MFT to REL1_18:...hashar08:57, 16 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84254documentation for BacklinkCache class...hashar18:12, 18 March 2011

Status & tagging log