r90809 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90808‎ | r90809 | r90810 >
Date:00:47, 26 June 2011
Author:nad
Status:deferred
Tags:
Comment:
use just one quote type in the evaled DB class creation
Modified paths:
  • /trunk/extensions/SimpleSecurity/SimpleSecurity_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SimpleSecurity/SimpleSecurity_body.php
@@ -389,8 +389,7 @@
390390 # - query method is overriden to ensure that old_id field is returned for all queries which read old_text field
391391 # - only SELECT statements are ever patched
392392 # - fetchObject method is overridden to validate row content based on old_id
393 - $oldClass = ucfirst( $wgDBtype );
394 - eval( "class Database_SimpleSecurity extends Database{$oldClass}" . ' {
 393+ eval( 'class Database_SimpleSecurity extends Database' . ucfirst( $wgDBtype ) . ' {
395394 public function query( $sql, $fname = "", $tempIgnore = false ) {
396395 $patched = preg_replace_callback( "/(?<=SELECT ).+?(?= FROM)/", array("SimpleSecurity", "patchSQL"), $sql, 1 );
397396 return parent::query( $patched, $fname, $tempIgnore );

Status & tagging log