r908 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r907‎ | r908 | r909 >
Date:12:59, 12 November 2002
Author:eloquence
Status:old
Tags:
Comment:
* changed quickbar navigation link names as discussed on wikipedia-l
* bugfix: Watch list link was shown even if user wasn't logged in
* bugfix: "Move this page" was redundantly shown as "Protected page"
if page was protected
Modified paths:
  • /trunk/phpwiki/newcodebase/Language.php (modified) (history)
  • /trunk/phpwiki/newcodebase/LocalSettings.php (modified) (history)
  • /trunk/phpwiki/newcodebase/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phpwiki/newcodebase/LocalSettings.php
@@ -6,22 +6,23 @@
77
88 # URLs for the wiki site
99 #
10 -$wgServer = "http://www.myhost.com";
11 -$wgStyleSheetPath = "$wgServer/style";
 10+$wgServer = "http://chesoo.fokus.gmd.de/cvswp";
 11+$wgStyleSheetPath = "$wgServer/stylesheets";
1212 $wgScript = "/wiki.phtml";
1313 $wgRedirectScript = "/redirect.phtml";
1414 $wgArticlePath = "$wgServer$wgScript?title=$1";
15 -$wgUploadPath = "http://www.myhost.com/upload";
16 -$wgUploadDirectory = "/usr/local/apache/htdocs/upload";
 15+$wgUploadPath = "$wgServer/images";
 16+$wgUploadDirectory = "/var/www/htdocs/cvswp/images";
1717 $wgLogo = "$wgUploadPath/wiki.png";
 18+$wgLanguageCode = "en";
1819
1920 # MySQL settings
2021 #
21 -$wgDBserver = "127.0.0.1";
 22+$wgDBserver = "localhost";
2223 $wgDBname = "wikidb";
23 -$wgDBuser = "wikiuser";
24 -$wgDBpassword = "userpass";
25 -$wgDBadminpassword = "adminpass";
 24+$wgDBuser = "nobody";
 25+$wgDBpassword = "suppball";
 26+$wgDBadminpassword = "suppball";
2627 $wgDBminWordLen = 3;
2728
2829 # Turn this on during database maintenance
@@ -31,7 +32,7 @@
3233 # Turn this on to get HTML debug comments
3334 #
3435 # $wgDebugComments = true;
35 -$wgDebugLogFile = "/usr/local/apache/htdocs/upload/logfile";
 36+# $wgDebugLogFile = "/usr/local/apache/htdocs/upload/logfile";
3637
3738 # Which interwiki prefix represents _this_ wiki? This
3839 # only needs to be set when installing the software on
Index: trunk/phpwiki/newcodebase/Skin.php
@@ -457,16 +457,16 @@
458458 $sep = "\n<br>";
459459 $s .= $this->mainPageLink()
460460 . $sep . $this->specialLink( "recentchanges" )
461 - . $sep . $this->specialLink( "randompage" )
462 - . $sep . $this->specialLink( "watchlist" ) ;
 461+ . $sep . $this->specialLink( "randompage" );
 462+ if ($wgUser->getID()) $s.= $sep . $this->specialLink( "watchlist" ) ; // only show watchlist link if logged in
463463 if ( wfMsg ( "currentevents" ) != "-" ) $s .= $sep . $this->makeKnownLink( wfMsg( "currentevents" ), "" ) ;
464464 $s .= "\n<hr>";
465465
466466 if ( $wgOut->isArticle() ) {
467467 $s .= "<strong>" . $this->editThisPage() . "</strong>";
468468 if ( 0 != $wgUser->getID() ) {
469 - $s .= $sep . $this->watchThisPage()
470 - . $sep . $this->moveThisPage();
 469+ $s .= $sep . $this->watchThisPage();
 470+ if ( $wgTitle->userCanEdit() ) $s .= $sep . $this->moveThisPage();
471471 }
472472 if ( $wgUser->isSysop() ) {
473473 $s .= $sep . $this->deleteThisPage() .
@@ -488,8 +488,8 @@
489489 if ( 0 != $wgUser->getID() ) {
490490 $s .= $this->specialLink( "upload" ) . $sep;
491491 }
492 - $s .= $this->bugReportsLink()
493 - . $sep . $this->specialLink( "specialpages" );
 492+ $s .= $this->specialLink( "specialpages" )
 493+ . $sep . $this->bugReportsLink();
494494
495495 $s .= "\n</div>\n";
496496 return $s;
@@ -650,9 +650,7 @@
651651 if ( $wgTitle->userCanEdit() ) {
652652 $s = $this->makeKnownLink( $wgLang->specialPage( "Movepage" ),
653653 wfMsg( "movethispage" ), "target=" . $wgTitle->getPrefixedURL() );
654 - } else {
655 - $s = wfMsg( "protectedpage" );
656 - }
 654+ } // no message if page is protected - would be redundant
657655 return $s;
658656 }
659657
Index: trunk/phpwiki/newcodebase/Language.php
@@ -294,14 +294,14 @@
295295 "whatlinkshere" => "Pages that link here",
296296 "help" => "Help",
297297 "search" => "Search",
298 -"history" => "History",
 298+"history" => "Older versions",
299299 "printableversion" => "Printable version",
300300 "editthispage" => "Edit this page",
301301 "deletethispage" => "Delete this page",
302302 "protectthispage" => "Protect this page",
303303 "unprotectthispage" => "Unprotect this page",
304 -"talkpage" => "Talk page",
305 -"subjectpage" => "Subject page",
 304+"talkpage" => "Discuss this page",
 305+"subjectpage" => "View article",
306306 "otherlanguages" => "Other languages",
307307 "redirectedfrom" => "(Redirected from $1)",
308308 "lastmodified" => "The page was last modified $1.",
@@ -593,7 +593,7 @@
594594
595595 # Upload
596596 #
597 -"upload" => "Upload",
 597+"upload" => "Upload file",
598598 "uploadbtn" => "Upload file",
599599 "uploadlink" => "Upload images",
600600 "reupload" => "Re-upload",
@@ -743,7 +743,7 @@
744744 "sysopspheading" => "Special pages for sysop use",
745745 "developerspheading" => "Special pages for developer use",
746746 "protectpage" => "Protect page",
747 -"recentchangeslinked" => "Watch links",
 747+"recentchangeslinked" => "Related changes",
748748 "rclsub" => "(to pages linked from \"$1\")",
749749 "debug" => "Debug",
750750 "newpages" => "New pages",
@@ -787,7 +787,7 @@
788788
789789 # Watchlist
790790 #
791 -"watchlist" => "Watch list",
 791+"watchlist" => "My watchlist",
792792 "watchlistsub" => "(for user \"$1\")",
793793 "nowatchlist" => "You have no items on your watchlist.",
794794 "watchnologin" => "Not logged in",

Status & tagging log