r90773 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90772‎ | r90773 | r90774 >
Date:16:30, 25 June 2011
Author:reedy
Status:ok
Tags:todo 
Comment:
Hack followup to r90643

Comment out the call SHOW SLAVE STATUS for getting replag, leaving the use processlist

Not sure when Tim/someone else will look at it, so easier to just hack the bad code for the moment, so people can develop/test etc
Modified paths:
  • /trunk/phase3/includes/db/DatabaseMysql.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseMysql.php
——@@ -365,9 +365,9 @@
366366 return $this->mFakeSlaveLag;
367367 }
368368
369 - if ( version_compare( $this->getServerVersion(), '4.1.9', '>=' ) ) {
 369+ /*if ( version_compare( $this->getServerVersion(), '4.1.9', '>=' ) ) {
370370 return $this->getLagFromSlaveStatus();
371 - } else {
 371+ } else */{
372372 return $this->getLagFromProcesslist();
373373 }
374374 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r95647* Fix for r90643: in the case where there is only one server, implying no rep...tstarling04:42, 29 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90643General database-related code cleanup:...tstarling03:14, 23 June 2011

Status & tagging log