r90705 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90704‎ | r90705 | r90706 >
Date:09:53, 24 June 2011
Author:salvatoreingala
Status:deferred
Tags:
Comment:
Follow up on r90322: removed unserialize() warning suppression
Modified paths:
  • /branches/salvatoreingala/Gadgets/backend/GadgetHooks.php (modified) (history)

Diff [purge]

Index: branches/salvatoreingala/Gadgets/backend/GadgetHooks.php
@@ -181,9 +181,7 @@
182182 $m = array();
183183 if ( preg_match( '/gadget-([a-zA-Z](?:[-_:.\w\d ]*[a-zA-Z0-9])?)-config/', $option, $m ) ) {
184184 $gadgetName = $m[1];
185 - wfSuppressWarnings();
186185 $gadgetPrefs = unserialize( $value );
187 - wfRestoreWarnings();
188186 if ( $gadgetPrefs !== false ) {
189187 $preferencesCache[$gadgetName] = $gadgetPrefs;
190188 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90322- Using serialize()/unserialize() to save and retrieve from DB....salvatoreingala21:55, 17 June 2011

Status & tagging log