r90703 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90702‎ | r90703 | r90704 >
Date:09:46, 24 June 2011
Author:salvatoreingala
Status:deferred
Tags:
Comment:
Reverts r90283
Modified paths:
  • /branches/salvatoreingala/Gadgets/api/ApiGetGadgetPrefs.php (modified) (history)

Diff [purge]

Index: branches/salvatoreingala/Gadgets/api/ApiGetGadgetPrefs.php
@@ -49,7 +49,7 @@
5050 $userPrefs = $gadget->getPrefs();
5151
5252 if ( $userPrefs === null ) {
53 - $this->dieUsage( 'An unexpected condition happened, please report this to the developers', 'unexpectederror' );
 53+ throw new MWException( __METHOD__ . ': $userPrefs should not be null.' );
5454 }
5555
5656 //Add user preferences to preference description

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90283Using dieUsage instead of MWException. Fixes r90272.salvatoreingala16:06, 17 June 2011

Status & tagging log