r90686 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90685‎ | r90686 | r90687 >
Date:00:39, 24 June 2011
Author:neilk
Status:ok
Tags:
Comment:
merged r90649
Modified paths:
  • /branches/REL1_18/extensions/UploadWizard/resources/mw.Api.js (modified) (history)

Diff [purge]

Index: branches/REL1_18/extensions/UploadWizard/resources/mw.Api.js
@@ -122,7 +122,11 @@
123123 ajax: function( parameters, ajaxOptions ) {
124124 parameters = $j.extend( {}, this.defaults.parameters, parameters );
125125 ajaxOptions = $j.extend( {}, this.defaults.ajax, ajaxOptions );
126 - ajaxOptions.data = parameters;
 126+
 127+ // Some deployed MediaWiki >= 1.17 forbid periods in URLs, due to an IE XSS bug
 128+ // So let's escape them here. See bug #28235
 129+ // This works because jQuery accepts data as a query string or as an Object
 130+ ajaxOptions.data = $j.param( parameters ).replace( /\./g, '%2E' );
127131
128132 ajaxOptions.error = function( xhr, textStatus, exception ) {
129133 ajaxOptions.err( 'http', { xhr: xhr, textStatus: textStatus, exception: exception } );
Property changes on: branches/REL1_18/extensions/UploadWizard/resources/mw.Api.js
___________________________________________________________________
Added: svn:mergeinfo
130134 Merged /trunk/extensions/UploadWizard/resources/mw.Api.js:r90649
131135 Merged /trunk/phase3/extensions/UploadWizard/resources/mw.Api.js:r85939
132136 Merged /branches/uploadwizard/extensions/UploadWizard/resources/mw.Api.js:r73550-75905

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90649encode periods in API arguments. There are now countermeasures in MediaWiki t...neilk06:19, 23 June 2011

Status & tagging log