r90654 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90653‎ | r90654 | r90655 >
Date:07:20, 23 June 2011
Author:tstarling
Status:ok
Tags:
Comment:
MFT r90653: SQL error
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/SubPageList3 (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/SubPageList3/SubPageList3.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/SubPageList3/SubPageList3.php
@@ -362,7 +362,7 @@
363363 $order = strtoupper( $this->order );
364364
365365 if( $this->ordermethod == 'title' ) {
366 - $options['ORDER BY'] = 'page_title' . $order;
 366+ $options['ORDER BY'] = 'page_title ' . $order;
367367 } elseif( $this->ordermethod == 'lastedit' ) {
368368 $options['ORDER BY'] = 'page_touched ' . $order;
369369 }
Property changes on: branches/wmf/1.17wmf1/extensions/SubPageList3
___________________________________________________________________
Added: svn:mergeinfo
370370 Merged /branches/new-installer/phase3/extensions/SubPageList3:r43664-66004
371371 Merged /branches/wmf-deployment/extensions/SubPageList3:r60970
372372 Merged /branches/REL1_15/phase3/extensions/SubPageList3:r51646
373373 Merged /branches/wmf/1.16wmf4/extensions/SubPageList3:r67177,69199,76243,77266
374374 Merged /trunk/extensions/SubPageList3:r90653
375375 Merged /branches/sqlite/extensions/SubPageList3:r58211-58321
376376 Merged /trunk/phase3/extensions/SubPageList3:r79828,79830,79848,79853,79950-79951,79954,79989,80006-80007,80013,80016,80080,80083,80124,80128,80238,80406,81833,83212,83590

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90653Fix SQL error due to r85594: missing space after page_title. Apparently "orde...tstarling07:19, 23 June 2011

Status & tagging log