r90634 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90633‎ | r90634 | r90635 >
Date:23:38, 22 June 2011
Author:dale
Status:deferred
Tags:
Comment:
work around bug in message parser by not including bold tag around link
removed relativeCortadoAppletPath ref
set EmbedPlayer.WebPath from extension hooks so TMH knows how to find cortado applet
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/EmbedPlayer.i18n.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerJava.js (modified) (history)
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js (modified) (history)
  • /trunk/extensions/TimedMediaHandler/TimedMediaHandler.hooks.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/TimedMediaHandler.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/TimedMediaHandler.php
@@ -20,7 +20,7 @@
2121
2222 /*** MwEmbed module configuration: *********************************/
2323 // Show a warning to the user if they are not using an html5 browser with high quality ogg support
24 -$wgMwEmbedModuleConfig['EmbedPlayer.DirectFileLinkWarning'] = true;
 24+$wgMwEmbedModuleConfig['EmbedPlayer.DirectFileLinkWarning'] = true;
2525
2626 // The text interface should always be shown
2727 // ( even if there are no text tracks for that asset at render time )
Index: trunk/extensions/TimedMediaHandler/TimedMediaHandler.hooks.php
@@ -18,6 +18,11 @@
1919 MwEmbedResourceManager::register( 'extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer' );
2020 MwEmbedResourceManager::register( 'extensions/TimedMediaHandler/MwEmbedModules/TimedText' );
2121
 22+ // Set the default webPath for this embed player extension
 23+ global $wgExtensionAssetsPath, $wgMwEmbedModuleConfig, $timedMediaDir;
 24+ $wgMwEmbedModuleConfig['EmbedPlayer.WebPath'] = $wgExtensionAssetsPath .
 25+ '/' . basename ( $timedMediaDir ) . '/MwEmbedModules/EmbedPlayer';
 26+
2227 // Setup media Handlers:
2328 $wgMediaHandlers['application/ogg'] = 'OggHandler';
2429 $wgMediaHandlers['video/webm'] = 'WebMHandler';
Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
@@ -716,7 +716,6 @@
717717 gM( 'mwe-embedplayer-for_best_experience', mw.getConfig('EmbedPlayer.FirefoxLink') )
718718 );
719719 }
720 -
721720 // Do png fix for ie6
722721 if ( $.browser.msie && $.browser.version <= 6 ) {
723722 $( '#' + embedPlayer.id + ' .play-btn-large' ).pngFix();
Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerJava.js
@@ -101,9 +101,7 @@
102102 if (
103103 !mw.isLocalDomain( mediaSrc )
104104 ||
105 - !mw.isLocalDomain( mw.getMwEmbedPath()
106 - ||
107 - mw.getConfig( 'relativeCortadoAppletPath' ) === false )
 105+ !mw.isLocalDomain( mw.getMwEmbedPath() )
108106 ){
109107 if ( window.cortadoDomainLocations[ new mw.Uri( mediaSrc ).host ] ) {
110108 appletLoc = window.cortadoDomainLocations[ new mw.Uri( mediaSrc ).host ];
Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/EmbedPlayer.i18n.php
@@ -61,7 +61,7 @@
6262 'mwe-embedplayer-ogg-player-kplayer' => 'Kaltura player',
6363 'mwe-embedplayer-ogg-player-selected' => '(selected)',
6464 'mwe-embedplayer-ogg-player-omtkplayer' => 'OMTK Flash Vorbis',
65 - 'mwe-embedplayer-for_best_experience' => 'For a better video playback experience we recommend the <b>[$1 latest Firefox].</b>',
 65+ 'mwe-embedplayer-for_best_experience' => 'For a better video playback experience we recommend the [$1 latest Firefox].',
6666 'mwe-embedplayer-download-warn' => 'No compatible in browser player was detected, for in browser playback please download the [$1 latest Firefox]',
6767 'mwe-embedplayer-fullscreen-tip' => 'Press <b>F11</b> toggle <i>web browser</i> fullscreen',
6868 'mwe-embedplayer-fullscreen-tip-osx' => 'Press <b>shift ⌘ F</b> to toggle fullscreen',

Status & tagging log