r90592 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90591‎ | r90592 | r90593 >
Date:18:02, 22 June 2011
Author:ialex
Status:ok
Tags:
Comment:
Removed usage of error suppression operator
Modified paths:
  • /trunk/phase3/includes/Import.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Import.php
@@ -1254,7 +1254,9 @@
12551255 }
12561256
12571257 static function newFromFile( $filename ) {
1258 - $file = @fopen( $filename, 'rt' );
 1258+ wfSuppressWarnings();
 1259+ $file = fopen( $filename, 'rt' );
 1260+ wfRestoreWarnings();
12591261 if( !$file ) {
12601262 return Status::newFatal( "importcantopen" );
12611263 }

Status & tagging log