r90452 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90451‎ | r90452 | r90453 >
Date:09:35, 20 June 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Partial revert of r86734: restore mPrefix - I still don't know what it does
Modified paths:
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -37,6 +37,9 @@
3838 /// For links
3939 protected $extraParams = array();
4040
 41+ /// No idea, apparently used by some other classes
 42+ protected $mPrefix;
 43+
4144 const NAMESPACES_CURRENT = 'sense';
4245
4346 public function __construct() {
@@ -84,6 +87,7 @@
8588 */
8689 public function load( &$request, &$user ) {
8790 list( $this->limit, $this->offset ) = $request->getLimitOffset( 20, 'searchlimit' );
 91+ $this->mPrefix = $request->getVal( 'prefix', '' );
8892
8993
9094 # Extract manually requested namespaces
@@ -179,6 +183,7 @@
180184 $search->setNamespaces( $this->namespaces );
181185 $search->showRedirects = $this->searchRedirects; // BC
182186 $search->setFeatureData( 'list-redirects', $this->searchRedirects );
 187+ $search->prefix = $this->mPrefix;
183188 $term = $search->transformSearchTerm($term);
184189
185190 wfRunHooks( 'SpecialSearchSetupEngine', array( $this, $this->profile, $search ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86734Cleanup next/prev links on special:search. Removed unused mPrefix.nikerabbit20:12, 22 April 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:06, 21 June 2011

Needs backport to 1.18 to avoid removing the Lucene search extension's prefix support.

Status & tagging log