r90435 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90434‎ | r90435 | r90436 >
Date:07:40, 20 June 2011
Author:tstarling
Status:ok
Tags:
Comment:
Revert the dbname -> dbName part of r90430. dbname actually dates back to r32578 and is referenced in the documentation for $wgDBservers, so it can't be easily changed. We can still kill tablename though, it's not too late.
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)
  • /trunk/phase3/includes/extauth/MediaWiki.php (modified) (history)
  • /trunk/phase3/includes/extauth/vB.php (modified) (history)
  • /trunk/phase3/includes/filerepo/ForeignDBRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -604,7 +604,7 @@
605605 *
606606 * @param $dbType String A possible DB type
607607 * @param $p Array An array of options to pass to the constructor.
608 - * Valid options are: host, user, password, dbName, flags, tablePrefix
 608+ * Valid options are: host, user, password, dbname, flags, tablePrefix
609609 * @return DatabaseBase subclass or null
610610 */
611611 public final static function factory( $dbType, $p = array() ) {
@@ -619,7 +619,7 @@
620620 isset( $p['host'] ) ? $p['host'] : false,
621621 isset( $p['user'] ) ? $p['user'] : false,
622622 isset( $p['password'] ) ? $p['password'] : false,
623 - isset( $p['dbName'] ) ? $p['dbName'] : false,
 623+ isset( $p['dbname'] ) ? $p['dbname'] : false,
624624 isset( $p['flags'] ) ? $p['flags'] : 0,
625625 isset( $p['tablePrefix'] ) ? $p['tablePrefix'] : 'get from global'
626626 );
Index: trunk/phase3/includes/filerepo/ForeignDBRepo.php
@@ -40,7 +40,7 @@
4141 'host' => $this->dbServer,
4242 'user' => $this->dbUser,
4343 'password' => $this->dbPassword,
44 - 'dbName' => $this->dbName,
 44+ 'dbname' => $this->dbName,
4545 'flags' => $this->dbFlags,
4646 'tablePrefix' => $this->tablePrefix
4747 )
Index: trunk/phase3/includes/extauth/MediaWiki.php
@@ -94,7 +94,7 @@
9595 'host' => $wgExternalAuthConf['DBserver'],
9696 'user' => $wgExternalAuthConf['DBuser'],
9797 'password' => $wgExternalAuthConf['DBpassword'],
98 - 'dbName' => $wgExternalAuthConf['DBname'],
 98+ 'dbname' => $wgExternalAuthConf['DBname'],
9999 'tablePrefix' => $wgExternalAuthConf['DBprefix'],
100100 )
101101 );
Index: trunk/phase3/includes/extauth/vB.php
@@ -33,7 +33,7 @@
3434 * 'server' => 'localhost',
3535 * 'username' => 'forum',
3636 * 'password' => 'udE,jSqDJ<""p=fI.K9',
37 - * 'dbName' => 'forum',
 37+ * 'dbname' => 'forum',
3838 * 'tablePrefix' => '',
3939 * 'cookieprefix' => 'bb'
4040 * );
@@ -107,7 +107,7 @@
108108 $wgExternalAuthConf['server'],
109109 $wgExternalAuthConf['username'],
110110 $wgExternalAuthConf['password'],
111 - $wgExternalAuthConf['dbName'],
 111+ $wgExternalAuthConf['dbname'],
112112 0,
113113 $wgExternalAuthConf['tablePrefix']
114114 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r32578* Introduced LBFactory -- an abstract class for configuring database load bal...tstarling09:48, 30 March 2008
r90430Fixes for r80864 for 1.18 backport:...tstarling07:00, 20 June 2011

Status & tagging log