r90432 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90431‎ | r90432 | r90433 >
Date:07:19, 20 June 2011
Author:tstarling
Status:ok
Tags:
Comment:
Fix for fatal error in r90429: you can't have a protected function in an interface.
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -43,14 +43,6 @@
4444 function open( $server, $user, $password, $dbName );
4545
4646 /**
47 - * The DBMS-dependent part of query()
48 - *
49 - * @param $sql String: SQL query.
50 - * @return Result object to feed to fetchObject, fetchRow, ...; or false on failure
51 - */
52 - protected function doQuery( $sql );
53 -
54 - /**
5547 * Fetch the next row from the given result object, in object form.
5648 * Fields can be retrieved with $row->fieldname, with fields acting like
5749 * member variables.
@@ -685,6 +677,14 @@
686678 }
687679
688680 /**
 681+ * The DBMS-dependent part of query()
 682+ *
 683+ * @param $sql String: SQL query.
 684+ * @return Result object to feed to fetchObject, fetchRow, ...; or false on failure
 685+ */
 686+ protected abstract function doQuery( $sql );
 687+
 688+ /**
689689 * Determine whether a query writes to the DB.
690690 * Should return true if unsure.
691691 *

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90429In Database.php:...tstarling06:52, 20 June 2011

Status & tagging log