| Index: trunk/phase3/RELEASE-NOTES-1.19 |
| — | — | @@ -105,6 +105,8 @@ |
| 106 | 106 | consecutive edits by same user in included diff, but then linked to |
| 107 | 107 | a single ungrouped diff. |
| 108 | 108 | * Do not try to group together a page creation and edit in the RSS feed of RC. |
| | 109 | +* (bug 29342) Patrol preferences shouldn't be visible to users who don't have |
| | 110 | + patrol permissions |
| 109 | 111 | |
| 110 | 112 | === API changes in 1.19 === |
| 111 | 113 | * BREAKING CHANGE: action=watch now requires POST and token. |
| Index: trunk/phase3/includes/Preferences.php |
| — | — | @@ -745,12 +745,15 @@ |
| 746 | 746 | 'section' => 'editing/advancedediting', |
| 747 | 747 | 'label-message' => 'tog-showtoolbar', |
| 748 | 748 | ); |
| 749 | | - $defaultPreferences['minordefault'] = array( |
| 750 | | - 'type' => 'toggle', |
| 751 | | - 'section' => 'editing/advancedediting', |
| 752 | | - 'label-message' => 'tog-minordefault', |
| 753 | | - ); |
| 754 | 749 | |
| | 750 | + if ( $user->isAllowed( 'minoredit' ) ) { |
| | 751 | + $defaultPreferences['minordefault'] = array( |
| | 752 | + 'type' => 'toggle', |
| | 753 | + 'section' => 'editing/advancedediting', |
| | 754 | + 'label-message' => 'tog-minordefault', |
| | 755 | + ); |
| | 756 | + } |
| | 757 | + |
| 755 | 758 | if ( $wgUseExternalEditor ) { |
| 756 | 759 | $defaultPreferences['externaleditor'] = array( |
| 757 | 760 | 'type' => 'toggle', |
| — | — | @@ -815,7 +818,7 @@ |
| 816 | 819 | 'section' => 'rc/advancedrc', |
| 817 | 820 | ); |
| 818 | 821 | |
| 819 | | - if ( $wgUseRCPatrol ) { |
| | 822 | + if ( $wgUseRCPatrol && $user->isAllowed( 'patrol' ) ) { |
| 820 | 823 | $defaultPreferences['hidepatrolled'] = array( |
| 821 | 824 | 'type' => 'toggle', |
| 822 | 825 | 'section' => 'rc/advancedrc', |