r90373 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90372‎ | r90373 | r90374 >
Date:22:07, 18 June 2011
Author:platonides
Status:ok
Tags:
Comment:
Fix html injection. _html() was not escaping output for html due to a misnamed parameter.
Modified paths:
  • /trunk/tools/ToolserverI18N/Functions.php (modified) (history)

Diff [purge]

Index: trunk/tools/ToolserverI18N/Functions.php
@@ -51,7 +51,7 @@
5252 if ( is_string( $options ) ) {
5353 $options = array( 'domain' => $options );
5454 }
55 - $options = array_merge( $options, array( 'parse' => 'html' ) );
 55+ $options = array_merge( $options, array( 'escape' => 'html' ) );
5656 return _( $key, $options );
5757 }
5858 }
@@ -61,4 +61,4 @@
6262 function _e( $key, $options = array() ) {
6363 echo _( $key, $options );
6464 }
65 -}
\ No newline at end of file
 65+}

Status & tagging log