r90352 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90351‎ | r90352 | r90353 >
Date:18:11, 18 June 2011
Author:aaron
Status:ok
Tags:
Comment:
Use makeTitle instead of newFromText since it comes from the DB
Modified paths:
  • /trunk/phase3/includes/specials/SpecialNewimages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialNewimages.php
@@ -114,7 +114,7 @@
115115 $name = $row->img_name;
116116 $user = User::newFromId( $row->img_user );
117117
118 - $title = Title::newFromText( $name, NS_FILE );
 118+ $title = Title::makeTitle( NS_FILE, $name );
119119 $ul = $this->skin->link( $user->getUserpage(), $user->getName() );
120120
121121 $this->gallery->add(

Status & tagging log