r90335 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90334‎ | r90335 | r90336 >
Date:14:01, 18 June 2011
Author:platonides
Status:ok
Tags:
Comment:
Follow up r90320. The purpose of wfProfileIn/Out is to profile
the contents of the function. So it shall be the last instruction.
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -2091,7 +2091,6 @@
20922092 '<h2 id="mw-previewheader">' . htmlspecialchars( wfMsg( 'preview' ) ) . "</h2>" .
20932093 $wgOut->parse( $note ) . $conflict . "</div>\n";
20942094
2095 - wfProfileOut( __METHOD__ );
20962095 global $wgBetterDirectionality, $wgContLang;
20972096 if( $wgBetterDirectionality ) {
20982097 $getPageLang = $wgOut->parserOptions()->getTargetLanguage( $this->mTitle );
@@ -2099,6 +2098,7 @@
21002099 $realBodyAttribs = array( 'lang' => $pageLang->getCode(), 'dir' => $pageLang->getDir() );
21012100 $previewHTML = Html::rawElement( 'div', $realBodyAttribs, $previewHTML );
21022101 }
 2102+ wfProfileOut( __METHOD__ );
21032103 return $previewhead . $previewHTML . $this->previewTextAfterContent;
21042104 }
21052105

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90320Follow-up to r90265: directionality improvements as part of bug 6100 (under $...robin21:48, 17 June 2011

Status & tagging log