r90249 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90248‎ | r90249 | r90250 >
Date:23:53, 16 June 2011
Author:reedy
Status:ok
Tags:
Comment:
StubUser was last in 1.16

No idea when StubTitle was last used

Fixup return documentation
Modified paths:
  • /trunk/extensions/MoodBar/FeedbackItem.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/FeedbackItem.php
@@ -47,7 +47,7 @@
4848 * @param $info Associative array of values
4949 * Valid keys: type, user, comment, page, flags, timestamp,
5050 * useragent, system, locale, bucket, anonymize
51 - * @return MBFeedback object.
 51+ * @return MBFeedbackItem object.
5252 */
5353 public static function create( $info ) {
5454 $newObject = new self();
@@ -170,9 +170,9 @@
171171 */
172172 public function validatePropertyValue( $key, $value ) {
173173 if ( $key == 'user' ) {
174 - return $value instanceof User || $value instanceof StubUser;
 174+ return $value instanceof User;
175175 } elseif ( $key == 'page' ) {
176 - return $value instanceof Title || $value instanceof StubTitle;
 176+ return $value instanceof Title;
177177 } elseif ( $key == 'type' ) {
178178 return in_array( $value, self::$validTypes );
179179 }

Status & tagging log