r90247 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90246‎ | r90247 | r90248 >
Date:23:36, 16 June 2011
Author:mah
Status:ok
Tags:
Comment:
follow up r84134 — removing passing $this by reference
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -2233,7 +2233,7 @@
22342234 * @param $group String Name of the group to add
22352235 */
22362236 function addGroup( $group ) {
2237 - if( wfRunHooks( 'UserAddGroup', array( &$this, &$group ) ) ) {
 2237+ if( wfRunHooks( 'UserAddGroup', array( $this, &$group ) ) ) {
22382238 $dbw = wfGetDB( DB_MASTER );
22392239 if( $this->getId() ) {
22402240 $dbw->insert( 'user_groups',
@@ -2259,7 +2259,7 @@
22602260 */
22612261 function removeGroup( $group ) {
22622262 $this->load();
2263 - if( wfRunHooks( 'UserRemoveGroup', array( &$this, &$group ) ) ) {
 2263+ if( wfRunHooks( 'UserRemoveGroup', array( $this, &$group ) ) ) {
22642264 $dbw = wfGetDB( DB_MASTER );
22652265 $dbw->delete( 'user_groups',
22662266 array(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84134Fix Bug #28082, Add Hooks to User::addGroup and User::removeGroup...mah23:13, 16 March 2011

Status & tagging log