r90146 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90145‎ | r90146 | r90147 >
Date:20:42, 15 June 2011
Author:brion
Status:ok
Tags:
Comment:
Another partial fix for Block test: update $this->mId on successful Block::insert()
Modified paths:
  • /trunk/phase3/includes/Block.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Block.php
@@ -415,10 +415,11 @@
416416 array( 'IGNORE' )
417417 );
418418 $affected = $dbw->affectedRows();
 419+ $this->mId = $dbw->insertId();
419420
420421 if ( $affected ) {
421422 $auto_ipd_ids = $this->doRetroactiveAutoblock();
422 - return array( 'id' => $ipb_id, 'autoIds' => $auto_ipd_ids );
 423+ return array( 'id' => $this->mId, 'autoIds' => $auto_ipd_ids );
423424 }
424425
425426 return false;

Status & tagging log