r90135 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90134‎ | r90135 | r90136 >
Date:18:44, 15 June 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: MFT r90133, r90134
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/WikiLove (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/WikiLove/WikiLove.hooks.php (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/WikiLove/WikiLove.hooks.php
@@ -64,10 +64,12 @@
6565 }
6666
6767 /**
68 - * Exports wikilove-recipient variable to JS
 68+ * Exports wikilove-recipient and edittoken variables to JS
6969 */
7070 public static function makeGlobalVariablesScript( &$vars ) {
 71+ global $wgUser;
7172 $vars['wikilove-recipient'] = self::$recipient;
 73+ $vars['wikilove-edittoken'] = $wgUser->edittoken();
7274 return true;
7375 }
7476
Index: branches/wmf/1.17wmf1/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -384,7 +384,7 @@
385385 'text': wikitext,
386386 'message': message,
387387 'subject': subject,
388 - 'token': mw.user.tokens.get( 'editToken' )
 388+ 'token': mw.config.get( 'wikilove-edittoken' ) // after 1.17 this can become mw.user.tokens.get( 'editToken' )
389389 };
390390
391391 if ( email ) {
Property changes on: branches/wmf/1.17wmf1/extensions/WikiLove
___________________________________________________________________
Added: svn:mergeinfo
392392 Merged /branches/new-installer/phase3/extensions/WikiLove:r43664-66004
393393 Merged /branches/wmf-deployment/extensions/WikiLove:r60970
394394 Merged /branches/REL1_15/phase3/extensions/WikiLove:r51646
395395 Merged /branches/wmf/1.16wmf4/extensions/WikiLove:r67177,69199,76243,77266
396396 Merged /trunk/extensions/WikiLove:r90133-90134
397397 Merged /branches/sqlite/extensions/WikiLove:r58211-58321
398398 Merged /trunk/phase3/extensions/WikiLove:r79828,79830,79848,79853,79950-79951,79954,79989,80006-80007,80013,80016,80080,80083,80124,80128,80238,80406,81833,83212,83590

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90133Reverted r88565 for now for 1.17wmf1 compatibilityjanpaul12318:32, 15 June 2011
r90134Followup to r90133 as this was still incorrect.janpaul12318:39, 15 June 2011

Status & tagging log