r90104 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90103‎ | r90104 | r90105 >
Date:03:48, 15 June 2011
Author:tstarling
Status:ok
Tags:
Comment:
MFT r89855 and base r89839 plus release notes, fixing bug 29399: PostgreSQL installer broken with same install and web user
Modified paths:
  • /branches/REL1_17/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/PostgresInstaller.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/installer/PostgresInstaller.php
@@ -278,7 +278,9 @@
279279
280280 $same = $this->getVar( 'wgDBuser' ) === $this->getVar( '_InstallUser' );
281281
282 - if ( !$same ) {
 282+ if ( $same ) {
 283+ $exists = true;
 284+ } else {
283285 // Check if the web user exists
284286 // Connect to the database with the install user
285287 $status = $this->getPgConnection( 'create-db' );
@@ -321,7 +323,7 @@
322324 // The web user is conventionally the table owner in PostgreSQL
323325 // installations. Make sure the install user is able to create
324326 // objects on behalf of the web user.
325 - if ( $this->canCreateObjectsForWebUser() ) {
 327+ if ( $same || $this->canCreateObjectsForWebUser() ) {
326328 return Status::newGood();
327329 } else {
328330 return Status::newFatal( 'config-pg-not-in-role' );
Property changes on: branches/REL1_17/phase3/includes/installer/PostgresInstaller.php
___________________________________________________________________
Added: svn:mergeinfo
329331 Merged /branches/sqlite/includes/installer/PostgresInstaller.php:r58211-58321
330332 Merged /trunk/phase3/includes/installer/PostgresInstaller.php:r82845,82847-82848,84875,84881-84882,84970,84976,85021,85066,88658,89311,89529,89821,89839,89855
331333 Merged /branches/new-installer/phase3/includes/installer/PostgresInstaller.php:r43664-66004
332334 Merged /branches/wmf-deployment/includes/installer/PostgresInstaller.php:r53381
333335 Merged /branches/REL1_15/phase3/includes/installer/PostgresInstaller.php:r51646
Index: branches/REL1_17/phase3/RELEASE-NOTES
@@ -39,8 +39,11 @@
4040 upgrade PHP prior to upgrading MediaWiki.
4141
4242 === Changes since 1.17.0rc1 ===
 43+
4344 * Fixed syntax error in generated LocalSettings.php when a non-default user
44 -rights profile is chosen.
 45+ rights profile is chosen.
 46+* (bug 29399) Fixed PostgreSQL installation when the DB user for installation
 47+ is the same as the one for web access.
4548
4649 === Changes since 1.17 beta 1 ===
4750

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89839Make Pg installer work in the “common” case: follow up r89821 so that $ex...mah18:48, 10 June 2011
r89855Fix for r89821, r89839: we can skip certain tests if the web user is the same...tstarling22:33, 10 June 2011

Status & tagging log