r90042 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90041‎ | r90042 | r90043 >
Date:13:25, 14 June 2011
Author:freakolowsky
Status:ok
Tags:
Comment:
* interpreted the variable name "channel" a bit differently (10x Nikerabbit)
Modified paths:
  • /trunk/extensions/OracleTextSearch/maintainenceFixOTSLinks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OracleTextSearch/maintainenceFixOTSLinks.php
@@ -17,9 +17,9 @@
1818 public function execute() {
1919 $doAll = $this->hasOption( 'all' );
2020 if ($doAll) {
21 - $this->output( "Recreating all index links to documents ", 'OracleTextSearch' );
 21+ $this->output( "Recreating all index links to documents\n" );
2222 } else {
23 - $this->output( "Recreating missing index links to documents ", 'OracleTextSearch' );
 23+ $this->output( "Recreating missing index links to documents\n" );
2424 }
2525 $this->doRecreate($doAll);
2626 }
@@ -33,7 +33,7 @@
3434
3535 $searchWhere = $all ? '' : ' AND NOT EXISTS (SELECT null FROM '.$tbl_idx.' WHERE si_page=p.page_id AND si_url IS NOT null)';
3636 $result = $dbw->doQuery('SELECT p.page_id FROM '.$tbl_pag.' p WHERE p.page_namespace = '.NS_FILE.$searchWhere );
37 - $this->output( "[".$result->numRows()." files found] ", 'OracleTextSearch' );
 37+ $this->output( $result->numRows()." file(s) found\n" );
3838
3939 $syncIdx = false;
4040 $countDone = 0;
@@ -57,16 +57,17 @@
5858 }
5959
6060 if ( $syncIdx ) {
61 - $this->output( " Syncing... ", 'OracleTextSearch');
 61+ $this->output( "Syncing index... " );
6262 $index = $dbw->getProperty('mTablePrefix')."si_url_idx";
6363 $dbw->query( "CALL ctx_ddl.sync_index('$index')" );
 64+ $this->output( "Done\n" );
6465 }
6566
66 - $this->output(" Finished ($countDone processed", 'OracleTextSearch');
 67+ $this->output("Finished ($countDone processed" );
6768 if ( $countSkipped > 0 ) {
68 - $this->output(", $countSkipped skipped ", 'OracleTextSearch');
 69+ $this->output(", $countSkipped skipped " );
6970 }
70 - $this->output(")", 'OracleTextSearch');
 71+ $this->output(")\n" );
7172 }
7273 }
7374

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90040(Nikerabbit comments on r90038#c18029)...freakolowsky13:02, 14 June 2011

Status & tagging log