r90018 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90017‎ | r90018 | r90019 >
Date:22:35, 13 June 2011
Author:janpaul123
Status:ok
Tags:
Comment:
Fixed JS leakage
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -448,7 +448,7 @@
449449 }
450450
451451 var index = 0,
452 - loadingType = currentTypeOrSubtype
 452+ loadingType = currentTypeOrSubtype,
453453 loadingIndex = 0;
454454 $.ajax({
455455 url: mw.util.wikiScript( 'api' ),
@@ -476,7 +476,7 @@
477477 $.each( data.query.pages, function( id, page ) {
478478 if ( page.imageinfo && page.imageinfo.length ) {
479479 // build an image tag with the correct url and width
480 - $img = $( '<img/>' )
 480+ var $img = $( '<img/>' )
481481 .attr( 'src', page.imageinfo[0].thumburl )
482482 .attr( 'width', currentTypeOrSubtype.gallery.width )
483483 .hide()

Status & tagging log