r89961 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89960‎ | r89961 | r89962 >
Date:13:50, 13 June 2011
Author:neilk
Status:ok
Tags:
Comment:
do not use _new for new windows, use _blank
Modified paths:
  • /trunk/extensions/UploadWizard/resources/jquery/jquery.mwCoolCats.js (modified) (history)
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/jquery/jquery.mwCoolCats.js
@@ -90,7 +90,7 @@
9191 if ( isHidden ) {
9292 $li.hide();
9393 } else {
94 - $anchor.attr( { target: "_new", href: _catLink( cat ) } );
 94+ $anchor.attr( { target: "_blank", href: _catLink( cat ) } );
9595 $li.append( $j.fn.removeCtrl( null, 'mwe-upwiz-category-remove', function() { $li.remove(); } ) );
9696 }
9797 $container.find( 'ul' ).append( $li );
Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -1508,7 +1508,7 @@
15091509 // Set the thumbnail links so that they point to the image description page
15101510 $thumbnailWrapDiv.find( 'a' ).attr( {
15111511 'href': upload.imageinfo.descriptionurl,
1512 - 'target' : '_new'
 1512+ 'target' : '_blank'
15131513 } );
15141514 $thanksDiv.append( $thumbnailWrapDiv );
15151515

Status & tagging log