r89946 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89945‎ | r89946 | r89947 >
Date:06:56, 13 June 2011
Author:happydog
Status:ok
Tags:
Comment:
[CodeReview] Follow-up to r89187. The start argument makes no sense when 'all' is being used, so we ignore it in that case (as per the argument description).
Modified paths:
  • /trunk/extensions/CodeReview/svnImport.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/svnImport.php
@@ -33,19 +33,18 @@
3434 }
3535 }
3636
37 - $startRev = null;
38 - if ( $this->hasArg( 1 ) ) {
39 - $startRev = $this->getArg( 1 );
40 - }
41 -
4237 $repo = $this->getArg( 0 );
4338
4439 if ( $repo == "all" ) {
4540 $repoList = CodeRepository::getRepoList();
4641 foreach ( $repoList as $repoInfo ) {
47 - $this->importRepo( $repoInfo->getName(), $startRev, $cacheSize );
 42+ $this->importRepo( $repoInfo->getName(), null, $cacheSize );
4843 }
4944 } else {
 45+ $startRev = null;
 46+ if ( $this->hasArg( 1 ) ) {
 47+ $startRev = $this->getArg( 1 );
 48+ }
5049 $this->importRepo( $repo, $startRev, $cacheSize );
5150 }
5251 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89187More explicit codereedy21:00, 30 May 2011

Status & tagging log