r89934 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89933‎ | r89934 | r89935 >
Date:19:09, 12 June 2011
Author:ialex
Status:ok
Tags:
Comment:
Changed some magic __get method calls to accessors, were throwing notices
Modified paths:
  • /trunk/phase3/index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/index.php
@@ -130,14 +130,14 @@
131131 $cache = new HTMLFileCache( $wgTitle, $action );
132132 if ( $cache->isFileCacheGood( /* Assume up to date */ ) ) {
133133 /* Check incoming headers to see if client has this cached */
134 - if ( !$context->output->checkLastModified( $cache->fileCacheTime() ) ) {
 134+ if ( !$context->getOutput()->checkLastModified( $cache->fileCacheTime() ) ) {
135135 $cache->loadFromFileCache();
136136 }
137137 # Do any stats increment/watchlist stuff
138138 $article = Article::newFromTitle( $wgTitle, $context );
139139 $article->viewUpdates();
140140 # Tell OutputPage that output is taken care of
141 - $context->output->disable();
 141+ $context->getOutput()->disable();
142142 wfProfileOut( 'index.php-filecache' );
143143 $mediaWiki->finalCleanup();
144144 wfProfileOut( 'index.php' );

Status & tagging log