r89901 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89900‎ | r89901 | r89902 >
Date:00:17, 12 June 2011
Author:krinkle
Status:ok
Tags:
Comment:
Remove resize/arrow cursors from jquery.makeCollapsible
* In Safari they look nice (a visual clue which direction we're heading on-click) but on other browsers there is only a general arrow-icon that points both up and down, and other browsers have an even weirder cursor for this. Summarized: It's inconsistent and redundant with the text-label we already have.

(Poke r79083 CR)
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.makeCollapsible.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.makeCollapsible.css
@@ -1,20 +1,14 @@
22 /* See also jquery.makeCollapsible.js */
33 .mw-collapsible-toggle {
4 - float:right;
 4+ float: right;
55 }
6 -.mw-collapsible-toggle-expanded,
7 -.mw-collapsible-toggle-expanded a {
8 - cursor:n-resize;
9 -}
10 -.mw-collapsible-toggle-collapsed,
11 -.mw-collapsible-toggle-collapsed a {
12 - cursor:s-resize;
13 -}
 6+
147 /* list-items go as wide as their parent element, don't float them inside list items */
158 li .mw-collapsible-toggle {
16 - float:none;
 9+ float: none;
1710 }
 11+
1812 /* the added list item should have no list-style */
1913 .mw-collapsible-toggle-li {
20 - list-style:none;
21 -}
\ No newline at end of file
 14+ list-style: none;
 15+}

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79083Refactoring in RecentChanges/Watchlist:...happy-melon19:07, 27 December 2010

Status & tagging log