r89859 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89858‎ | r89859 | r89860 >
Date:23:14, 10 June 2011
Author:tstarling
Status:ok
Tags:
Comment:
* Hackish temporary fix for bug 28162 (wgDBport not respected). Needs proper constructor parameters.
* Fixed r89813: release notes in the wrong section and not written for the user audience.
Modified paths:
  • /branches/REL1_17/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/PostgresInstaller.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/installer/PostgresInstaller.php
@@ -115,6 +115,7 @@
116116 protected function openConnectionWithParams( $user, $password, $dbName ) {
117117 $status = Status::newGood();
118118 try {
 119+ $GLOBALS['wgDBport'] = $this->getVar( 'wgDBport' );
119120 $db = new DatabasePostgres(
120121 $this->getVar( 'wgDBserver' ),
121122 $user,
@@ -207,6 +208,7 @@
208209 $status = Status::newGood();
209210 foreach ( $dbs as $db ) {
210211 try {
 212+ $GLOBALS['wgDBport'] = $this->getVar( 'wgDBport' );
211213 $conn = new DatabasePostgres(
212214 $this->getVar( 'wgDBserver' ),
213215 $user,
Index: branches/REL1_17/phase3/RELEASE-NOTES
@@ -89,6 +89,10 @@
9090 * Fixed error caused by missing magic words.
9191 * Fixed breakage of article editing in PostgreSQL due to text search
9292 configuration errors.
 93+* Fixed the HTTPS client used when Curl is not available. This avoids an error
 94+ during install about failure of the mediawiki-announce subscription.
 95+* (bug 28162) When installing to PostgreSQL, respect the "database port" input,
 96+ it was ignored.
9397
9498 === Configuration changes in 1.17 ===
9599
@@ -600,7 +604,6 @@
601605 in IE 7.
602606 * (bug 17398) Fixed "link" parameter in image links with "thumb" or "frame"
603607 parameter.
604 -* (bug 27854) Http::isValidURI is way too lax.
605608
606609 === API changes in 1.17 ===
607610

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89813Followup r89812, RELEASE-NOTESdemon02:58, 10 June 2011

Status & tagging log