r89857 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89856‎ | r89857 | r89858 >
Date:22:36, 10 June 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
small tweak suggested by Katkov Yury
Modified paths:
  • /trunk/extensions/GraphViz/GraphViz.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GraphViz/GraphViz.php
@@ -286,9 +286,9 @@
287287 $storagename = str_replace( "%", '_perc_', urlencode( $title ) ) . '---'; // clean up pagename (special chars etc)
288288
289289 if ( $wgGraphVizSettings->named == 'md5' ) {
290 - $storagename .= md5( $timelinesrc ); // produce md5-hash out of the storagename !can be duplicate!
 290+ $storagename = md5( $storagename . $timelinesrc ); // produce md5-hash out of the storagename !can be duplicate!
291291 } elseif ( $wgGraphVizSettings->named == 'sha1' ) {
292 - $storagename .= sha1( $timelinesrc ); // produce sha1-hash
 292+ $storagename = sha1( $storagename . $timelinesrc ); // produce sha1-hash
293293 } else { // named == 'named'
294294 $storagename .= str_replace( "%", '_perc_',
295295 urlencode( trim( str_replace( array( "\n", "\\" ), array( '', '/' ),

Status & tagging log