r89842 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89841‎ | r89842 | r89843 >
Date:19:07, 10 June 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Got padding working using a ruler technique.
Modified paths:
  • /trunk/parsers/wikidom/lib/jquery.editSurface.css (modified) (history)
  • /trunk/parsers/wikidom/lib/jquery.flow.js (modified) (history)

Diff [purge]

Index: trunk/parsers/wikidom/lib/jquery.flow.js
@@ -164,9 +164,10 @@
165165 console.time( 'flow' );
166166
167167 var $this = $(this),
 168+ $ruler = $( '<div></div>' ).appendTo( $(this) ),
168169 lines = $.flow.getLines(
169170 $.flow.getWords( text, $( '<div class="editSurface-line"></div>' ).appendTo( $this )[0] ),
170 - $this.innerWidth()
 171+ $ruler.innerWidth()
171172 );
172173
173174 // Flow
Index: trunk/parsers/wikidom/lib/jquery.editSurface.css
@@ -16,7 +16,7 @@
1717
1818 #selection p {
1919 margin: 0;
20 - padding: 0em;
 20+ padding: 2em;
2121 }
2222
2323 .editSurface-container {
@@ -28,7 +28,7 @@
2929 }
3030
3131 .editSurface-paragraph {
32 - padding: 0em;
 32+ padding: 2em;
3333 }
3434
3535 .editSurface-line {

Status & tagging log