r89824 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89823‎ | r89824 | r89825 >
Date:12:59, 10 June 2011
Author:tstarling
Status:ok
Tags:
Comment:
Fixed complete breakage of editing in PG, including the default main page which was missing, by doing a partial backport of r81439 to get the to_tsvector() calling convention update.
Modified paths:
  • /branches/REL1_17/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_17/phase3/maintenance/postgres/tables.sql (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/maintenance/postgres/tables.sql
@@ -495,7 +495,7 @@
496496 CREATE INDEX job_cmd_namespace_title ON job (job_cmd, job_namespace, job_title);
497497
498498 -- Tsearch2 2 stuff. Will fail if we don't have proper access to the tsearch2 tables
 499+-- Version 8.3 or higher only. Previous versions would need another parmeter for to_tsvector.
499500 -- Make sure you also change patch-tsearch2funcs.sql if the funcs below change.
500501
501502 ALTER TABLE page ADD titlevector tsvector;
@@ -503,9 +503,9 @@
504504 $mw$
505505 BEGIN
506506 IF TG_OP = 'INSERT' THEN
507 - NEW.titlevector = to_tsvector('default',REPLACE(NEW.page_title,'/',' '));
 507+ NEW.titlevector = to_tsvector(REPLACE(NEW.page_title,'/',' '));
508508 ELSIF NEW.page_title != OLD.page_title THEN
509 - NEW.titlevector := to_tsvector('default',REPLACE(NEW.page_title,'/',' '));
 509+ NEW.titlevector := to_tsvector(REPLACE(NEW.page_title,'/',' '));
510510 END IF;
511511 RETURN NEW;
512512 END;
@@ -520,9 +520,9 @@
521521 $mw$
522522 BEGIN
523523 IF TG_OP = 'INSERT' THEN
524 - NEW.textvector = to_tsvector('default',NEW.old_text);
 524+ NEW.textvector = to_tsvector(NEW.old_text);
525525 ELSIF NEW.old_text != OLD.old_text THEN
526 - NEW.textvector := to_tsvector('default',NEW.old_text);
 526+ NEW.textvector := to_tsvector(NEW.old_text);
527527 END IF;
528528 RETURN NEW;
529529 END;
Index: branches/REL1_17/phase3/RELEASE-NOTES
@@ -87,6 +87,8 @@
8888 any necessary database tables.
8989 * (bug 28983) Fixed automated installation of extensions that overwrite $path.
9090 * Fixed error caused by missing magic words.
 91+* Fixed breakage of article editing in PostgreSQL due to text search
 92+ configuration errors.
9193
9294 === Configuration changes in 1.17 ===
9395

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81439Results of my work on new-installer and Pg....mah04:06, 3 February 2011

Status & tagging log