r89809 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89808‎ | r89809 | r89810 >
Date:22:56, 9 June 2011
Author:krinkle
Status:deferred
Tags:
Comment:
fix bug with the hint icon (was displayed too high, margin didn't apply because the show() on the display:none <span> made it display:inline, not block.
Modified paths:
  • /trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/ext.styleguidedemo.css (modified) (history)
  • /trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/ext.styleguidedemo.js (modified) (history)

Diff [purge]

Index: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/ext.styleguidedemo.css
@@ -15,19 +15,20 @@
1616
1717 .mw-label {
1818 display: block;
 19+ position: relative;
1920 }
2021
 22+.mw-label label {
 23+ margin: 0px 0px 0px 16px;
 24+ font-weight: bold;
 25+}
 26+
2127 .mw-label .mw-help-field-hint {
22 - margin-bottom: -15px;
 28+ position: absolute; top: 2px; left: 0px;
2329 height: 12px;
2430 width: 12px;
2531 }
2632
27 -.mw-label label {
28 - margin: 0px 0px 0px 16px;
29 - font-weight: bold;
30 -}
31 -
3233 .mw-htmlform-tip {
3334 margin: 0px 0px 0px 30px;
3435 font-size: 10px;
Index: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/ext.styleguidedemo.js
@@ -8,7 +8,7 @@
99 .hide()
1010 .closest( '.mw-help-field-container' )
1111 .find( '.mw-help-field-hint' )
12 - .show()
 12+ .css( 'display', 'block' ) // <span>, so show() is not enough
1313 .click( function() {
1414 $(this)
1515 .closest( '.mw-help-field-container' )

Status & tagging log