r89757 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r89756
|
r89757
|
r89758
>
Date:
00:20, 9 June 2011
Author:
brion
Status:
ok
Tags:
Comment:
Fix for WikiEditor iframe extension on IE: use $.inArray() instead of Array.indexOf(), which is not in earlier JS standards as implemented in IE 8.
Use of Array.indexOf was added in
r74271
when the iframe bits were broken out to an extension.
Modified paths:
/trunk/extensions/WikiEditor/modules/jquery.wikiEditor.js
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.js
—
—
@@ -606,7 +606,7 @@
607
607
for ( var e in $.wikiEditor.extensions ) {
608
608
if (
609
609
$.wikiEditor.isRequired( $.wikiEditor.modules[module], e ) &&
610
- context.extensions.indexOf( e ) === -1
610
+ $.inArray( e, context.extensions ) === -1
611
611
) {
612
612
context.extensions[context.extensions.length] = e;
613
613
$.wikiEditor.extensions[e]( context );
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r74271
* Introduced the concept of context extensions...
tparscal
20:12, 4 October 2010
Status & tagging log
08:17, 9 June 2011
Catrope
(
talk
|
contribs
)
changed the
status
of r89757
[
removed:
new
added:
ok]