r89747 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89746‎ | r89747 | r89748 >
Date:20:37, 8 June 2011
Author:foxtrott
Status:deferred (Comments)
Tags:
Comment:
followup r89740: remove wfMsgReplaceArgs, small fix to messages
Modified paths:
  • /trunk/extensions/Lingo/Lingo.i18n.php (modified) (history)
  • /trunk/extensions/Lingo/LingoBasicBackend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Lingo/LingoBasicBackend.php
@@ -31,13 +31,13 @@
3232 // Get Terminology page
3333 $title = Title::newFromText( $page );
3434 if ( $title->getInterwiki() ) {
35 - $this->getMessageLog()->addError( wfMsgReplaceArgs( wfMsgForContent( 'lingo-terminologypagenotlocal' ), array($page) ) );
 35+ $this->getMessageLog()->addError( wfMsgForContent( 'lingo-terminologypagenotlocal' , array($page) ) );
3636 return false;
3737 }
3838
3939 $rev = Revision::newFromTitle( $title );
4040 if ( !$rev ) {
41 - $this->getMessageLog()->addWarning( wfMsgReplaceArgs( wfMsgForContent( 'lingo-noterminologypage' ), array($page) ) );
 41+ $this->getMessageLog()->addWarning( wfMsgForContent( 'lingo-noterminologypage' , array($page) ) );
4242 return false;
4343 }
4444
Index: trunk/extensions/Lingo/Lingo.i18n.php
@@ -11,8 +11,8 @@
1212 $messages['en'] = array(
1313 'lingo-desc' => 'Provides hover-over tool tips on pages from words defined on the [[$1]] page',
1414 'lingo-terminologypagename' => 'Terminology',
15 - 'lingo-noterminologypage' => 'Page "$1" does not exist.',
16 - 'lingo-terminologypagenotlocal' => 'Page "$1" is not a local page.',
 15+ 'lingo-noterminologypage' => "Page '$1' does not exist.",
 16+ 'lingo-terminologypagenotlocal' => "Page '$1' is not a local page.",
1717
1818 );
1919

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89740followup r89732: use wfMsgForContent, modify messagesfoxtrott20:18, 8 June 2011

Comments

#Comment by Nikerabbit (talk | contribs)   22:31, 8 June 2011

You don't need the array() either in the wfMsgForContent calls :)

#Comment by F.trott (talk | contribs)   07:34, 9 June 2011

Ok, will take them out with the next commit. Thanks for the review. :)

Status & tagging log